Repository navigation
docs(arch): describe Domain contracts and CW1004 in the code-layers table - #1124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1116 (no issue closes).
Two rows in the code-layers table of
docs/architecture.mdwere out of date after #1104 and #1116.Contracts/holds contract enums. The DomainContracts/folders now also hold value types (DiscountCeiling,CurrencyInfo) and static rules and constants (Roles,FarmCode,FarmImageErrors,CurrencyCatalog,SeedDefaults). The new row names three of them as examples.I checked the rest of the file. The feature-module prose ("reach it through its
Contracts/, Farm also declares a small seam") is still accurate, and every source path it cites still exists. The diagrams are unchanged.Guards that read tracked docs pass:
CouplingMatrixRealTreeTestsandTenancyDocsFreshnessTests(4/4), and theSchemaDocsTestsimage-pin guards (2/2).