Repository navigation
ci(deps): hold Roslyn at EF Core Design's version in Dependabot - #1111
Merged
Merged
Conversation
Microsoft.EntityFrameworkCore.Design pins Microsoft.CodeAnalysis.Workspaces.Common exactly through Workspaces.MSBuild, so raising Microsoft.CodeAnalysis.CSharp and CSharp.Workspaces ahead of it fails restore with NU1608 (#1110).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot PR #1110 raised
Microsoft.CodeAnalysis.CSharpandMicrosoft.CodeAnalysis.CSharp.Workspacesfrom 5.0.0 to 5.9.0. Restore then failed on every CI job.Cause.
Microsoft.EntityFrameworkCore.Design10.0.12 depends onMicrosoft.CodeAnalysis.Workspaces.MSBuild5.0.0, which requiresMicrosoft.CodeAnalysis.Workspaces.Commonat exactly[5.0.0]. The 5.9.0 bump resolvesWorkspaces.Common5.9.0, and restore reportsNU1608, which this build treats as an error. Regenerating the lock files cannot fix this, because the versions themselves conflict.Change. This PR adds a Dependabot
ignoreentry for these two packages only. OtherMicrosoft.CodeAnalysis.*packages, such asAnalyzer.Testing, still get updates.Follow-up. #1112 tracks removing the hold once an EF Core Design release depends on a newer Roslyn.
After this merges, close #1110. Dependabot will then open a new group PR without the Roslyn bump.