Add acceptance test for new wx modal error - #145
Merged
Merged
Conversation
2 tasks
bayliffe
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accompanies metoppv/improver#2440
Adds input and KGO that covers the new edge case fixed by the IMPROVER PR. The inputs contain only five sites to keep the files small, but there are 24 of them as I couldn't find a smaller subset that reproduced the error.
A side-effect is that
improver weather-symbols-modesnow enforces the IMPROVER metadata standard that the blend time will be the newest of the input blend times. Before this change, the blend time of the first input was used. One existing KGO is affected by this change because the 2nd and 4th inputs have newer blend times than the 1st and 3rd.