Skip to content

[cmake] Disable ZSTD_BUILD_PROGRAMS by default when zstd is a subproject - #4883

Open
crueter wants to merge 2 commits into
meta:devfrom
crueter:build-progs
Open

crueter wants to merge 2 commits into
meta:devfrom
crueter:build-progs

Conversation

@crueter

@crueter crueter commented Nov 1, 2026 •

Copy link
Copy Markdown

e.g. vendoring, no need to add these executables by default. Consumers can still opt-in however.

Signed-off-by: crueter crueter@eden-emu.dev

e.g. vendoring, no need to add these executables.

Signed-off-by: crueter <crueter@eden-emu.dev>
@meta-cla

meta-cla Bot commented Nov 1, 2026

Copy link
Copy Markdown

Hi @crueter!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Signed-off-by: crueter <crueter@eden-emu.dev>
@meta-cla meta-cla Bot added the CLA Signed label Nov 1, 2026
@crueter crueter changed the title [cmake] Disable ZSTD_BUILD_PROGRAMS when zstd is a subproject [cmake] Disable ZSTD_BUILD_PROGRAMS by default when zstd is a subproject Nov 1, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant