Repository navigation
Release 1.9.0: front sub-groups from parent artwork, DocC on SPI, Dependabot - #7
Merged
Merged
Conversation
The front sub-groups were placeholder ovals and dots placed over the parent muscle: two ovals inside each pectoral, a small circle on the shoulder, dots on the ribs and hips, and ovals on the thighs. Each one is now cut from its parent's own artwork: - upperChest / lowerChest: the pectoral split at about 42 % of its height, with a thin seam between the two parts. - frontDeltoid: the part of the deltoid next to the chest. On the male body the single deltoid shape is split so that part holds about 45 % of its area; the female artwork already separates the heads, so its inner head is used. - upperAbs / lowerAbs: the abdominal blocks above and below the middle of the abs column, using the existing block shapes. - serratus: the small finger-like slips in the upper half of the obliques. - hipFlexors: the top fifth of the main quadriceps shape (the rectus femoris origin). - innerQuad / outerQuad: the innermost and outermost quadriceps pieces (vastus medialis and vastus lateralis). Sub-groups are only drawn with .showSubGroups(), so the default rendering is unchanged; the existing snapshots still match. - New test: every sub-group lies inside its parent's bounds on all views. - New snapshots of the front sub-groups for both bodies. - New README screenshot front_subgroups next to back_regions.
- Add .spi.yml so the Swift Package Index builds and hosts the DocC
documentation for the MuscleMap target.
- New articles:
- "Sub-Groups and Regions": showing sub-groups, always-visible
sub-groups, the back regions and checking a mapping with isDrawable.
- "Accessibility": what VoiceOver reads, per-side elements and the 11
localizations.
- "Performance": the path cache, BodyView.preloadArtwork() and Swift 6
concurrency.
- Heatmap guide: a color scale's own interpolation is used unless a
non-linear one is set on the view.
- Getting Started: the package URL pointed at another account and an old
version; it now uses github.com/melihcolpan/MuscleMap.git, and the
CocoaPods line was added.
- Fix an ambiguous symbol link in the UIKit article. The documentation now
builds without warnings.
- Dependabot checks the GitHub Actions used by the workflow once a week and groups their updates into one pull request. - The iOS job now builds the DocC documentation and fails when it has warnings, such as a link to a symbol that was renamed or removed. Verified by adding a broken link: the check reports it and fails. - README: mention the documentation build, Dependabot and the hosted API documentation.
- Bump the podspec and the SPM / CocoaPods install snippets to 1.9.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The front sub-groups are redrawn from their parent muscles, the DocC documentation is published on the Swift Package Index, and CI gains Dependabot and a documentation check.
Front sub-groups
The front sub-groups were placeholder ovals and dots placed over the parent muscle. Each one is now cut from its parent's own artwork:
upperChestandlowerChestsplit the pectoral at about 42 % of its height, with a thin seam between them.frontDeltoidis the part of the deltoid next to the chest.upperAbsandlowerAbsare the abdominal blocks above and below the middle of the abs column.serratusis the finger-like slips on the ribs.hipFlexorsis the top of the quadriceps, at the rectus femoris origin.innerQuadandouterQuadare the innermost and outermost quadriceps pieces (vastus medialis and lateralis).Sub-groups are only drawn with
.showSubGroups(), so the default rendering is unchanged and the existing snapshots still match. A new test checks that every sub-group lies inside its parent, and new snapshots cover the front sub-groups.Documentation
.spi.ymllets the Swift Package Index build and host the DocC documentation.CI