Skip to content

compat.fribidi: -fPIC on linux and macOS only; static entry points on windows #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sunrisepeak merged 1 commit into from
Oct 26, 2026
Merged

compat.fribidi: -fPIC on linux and macOS only; static entry points on windows #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pkgs/c/compat.fribidi.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,17 @@ package = {
-- Upstream's own, from lib/meson.build: without it every public
-- symbol would be hidden and pango would fail to link.
"-DFRIBIDI_BUILD",
-- pango is linked into shared objects, so the objects must be
-- position independent.
"-fPIC",
},
-- pango is linked into shared objects, so the objects must be
-- position independent. Not on windows: PE/COFF has no such
-- distinction, and clang rejects -fPIC for the MSVC target.
linux = { cflags = { "-fPIC" } },
macosx = { cflags = { "-fPIC" } },
-- This is a static library: under _WIN32 fribidi-common.h would make
-- every entry point __declspec(dllexport) (dllimport for consumers)
-- unless FRIBIDI_LIB_STATIC says otherwise. A consumer that includes
-- the headers on windows defines it too.
windows = { cflags = { "-DFRIBIDI_LIB_STATIC" } },

targets = { fribidi = { kind = "lib" } },
},
Expand Down
Loading