Repository navigation
fix: correct CI pull_request target branch, update README - #2
Merged
Merged
Conversation
- CI pull_request now targets main+dev (was still master) - README settings endpoint no longer claims it exposes the API key
There was a problem hiding this comment.
Pull request overview
This PR aligns CI behavior with the repository’s current branch naming and corrects API documentation to reflect that /api/settings does not expose the API key.
Changes:
- Update GitHub Actions CI
pull_requesttrigger branches frommastertomain, devto match the existingpushtrigger. - Update README
/api/settingsendpoint description to indicate it returnshasKeyand never returns the key itself.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Clarifies /api/settings response semantics (returns hasKey, does not expose the API key). |
| .github/workflows/ci.yml | Fixes CI pull_request branch filters to run on PRs targeting main and dev. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
pull_requesttarget branches frommastertomain, dev(matching push trigger)