Skip to content

STF-1906: Add phone verification inputs to minFraud - #6

Open
oschwald wants to merge 1 commit into
mainfrom
greg/billing-phone-verification-inputs
Open

oschwald wants to merge 1 commit into
mainfrom
greg/billing-phone-verification-inputs

Conversation

@oschwald

@oschwald oschwald commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Adds three optional inputs to the minFraud request billing and shipping objects: phone_verification_method (delivered_code, network, or other), phone_was_verification_successful (boolean), and phone_verification_time (RFC 3339 date-time). They describe the most recent verification of the phone number. Both objects extend the shared Address schema, so the inputs live there. Risk scoring uses the shipping phone when the billing phone is absent. The request example and the bundled spec include the new fields.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • MinFraud requests can now include optional phone-verification details: the verification method, time, and whether the latest verification succeeded. Verification methods are limited to delivered code, network, or other.
    • Verification times earlier than January 1, 1970, or more than two days in the future are ignored with a warning.
  • Documentation
    • Updated billing and shipping request examples to show successful delivered-code verification.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: afa0f1fd-5767-4d89-abe7-224254323f79
📥 Commits

Reviewing files that changed from the base of the PR and between fc47b62 and 25b86c5.

📒 Files selected for processing: 3
  • bundled/minfraud.yaml
  • components/minfraud-request.yaml
  • examples/minfraud/request.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The minFraud Address request schema now defines optional phone-verification method, timestamp, and success fields. The bundled schema and billing and shipping request examples include the corresponding fields.

Changes: MinFraud phone verification

Layer / File(s) Summary
Phone-verification request fields
components/minfraud-request.yaml, bundled/minfraud.yaml
The Address schema defines optional verification method, time, and success fields. It limits methods to three values and specifies when timestamps are ignored with a warning.
Billing and shipping examples
bundled/minfraud.yaml, examples/minfraud/request.yaml
Billing and shipping examples include delivered-code verification methods, timestamps, and successful-verification values.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 25b86

The change adds optional phone-verification metadata. Different timestamps for the same number in billing and shipping are permitted as per-entry values, so no actionable merge risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding phone verification inputs to minFraud.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the fields with care,
Three methods hop into the schema there.
A timestamp joins the billing call,
Then shipping gets the same field set, all.
“Verified!” the bunny writes with glee,
And bounds away beneath the tree.

Comment @coderabbitai help to get the list of available commands.

@oschwald
oschwald force-pushed the greg/billing-phone-verification-inputs branch from cf60e92 to 444a3ae Compare October 12, 2026 14:56
@oschwald oschwald changed the title Add billing phone verification inputs to minFraud Add phone verification inputs to minFraud Oct 12, 2026
@oschwald
oschwald force-pushed the greg/billing-phone-verification-inputs branch 2 times, most recently from 34f8da7 to 5f40f16 Compare October 14, 2026 21:36
The minFraud request `billing` and `shipping` objects now accept three
optional inputs that describe the most recent verification of the phone
number: `phone_verification_method`, `phone_was_verification_successful`,
and `phone_verification_time`. Risk scoring uses the shipping phone when
the billing phone is absent.

Both objects share the `Address` schema, so the inputs live there. The
request example and the bundled spec include them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oschwald
oschwald force-pushed the greg/billing-phone-verification-inputs branch from 5f40f16 to 25b86c5 Compare October 15, 2026 22:04
@oschwald
oschwald marked this pull request as ready for review October 15, 2026 22:04
Copilot AI balanced review requested due to automatic review settings October 15, 2026 22:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@oschwald oschwald changed the title Add phone verification inputs to minFraud STF-1906: Add phone verification inputs to minFraud Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants