Repository navigation
chore(playground): keep loading grammars when Cache Storage refuses - #43
Merged
Merged
Conversation
maxgfr.github.io is one origin shared by every project site, so its storage quota can be filled by another site, and private windows may refuse Cache Storage altogether. A rejected caches.open, match or put made the grammar load fail even though the wasm had been fetched. The cache is now best effort: any of those failing falls back to the network copy. No package change: the playground is only deployed with the site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxgfr.github.io is one origin shared by every project site: its storage quota can be full because of another site, and private windows may refuse Cache Storage. A rejected
caches.open/match/putin the playground worker failed the grammar load even after a successful fetch. The grammar cache is now best effort and falls back to the network copy.Rest of the storage audit: theme key
codeindex-themeand cachecodeindex-grammars-v1are already app-scoped, writes are guarded, no cookies, no service worker, no shared wipes.chorerather thanfix: only site/ changes, so no npm release is needed.Tests:
pnpm typecheck, playground unit tests pass. Fullpnpm test: 5 CLI tests time out locally, identically on main (unrelated).