Repository navigation
[SPT-1668] Report the SDK version in the User-Agent and __version__ - #1041
Open
justinpolygon wants to merge 1 commit into
Open
justinpolygon wants to merge 1 commit into
justinpolygon wants to merge 1 commit into
Conversation
The version was looked up for the "massive-api-client" package, an unofficial third-party wrapper, instead of "massive". The User-Agent was "Massive.com PythonClient/unknown" for everyone (or the wrapper's version if it was installed). massive.__version__ was also set to the importlib.metadata.version function instead of the version string.
justinpolygon
marked this pull request as ready for review
October 16, 2026 20:17
justinpolygon
requested review from
jbonzo,
kschoche,
lukeoleson,
mmoghaddam385 and
suever
as code owners
October 16, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every request sent
User-Agent: Massive.com PythonClient/unknown, because the version was looked up formassive-api-client(an unofficial third-party wrapper) instead ofmassive. Andmassive.__version__was theimportlib.metadata.versionfunction rather than the version string. Both now report the installed version.Verified with a wheel built the way the release workflow does (
poetry version 2.9.1): it sendsMassive.com PythonClient/2.9.1andmassive.__version__ == "2.9.1". Published 2.9.0 sends/unknown. Tests are included.