Repository navigation
[SPT-1644] Log WebSocket server errors instead of dropping them - #1039
Merged
Merged
Conversation
justinpolygon
changed the title
justinpolygon
force-pushed
the
justin/spt-1644
branch
from
October 15, 2026 19:52
1a779d9 to
5a3323d
Compare
justinpolygon
marked this pull request as ready for review
October 16, 2026 19:27
justinpolygon
requested review from
jbonzo,
kschoche,
lukeoleson,
mmoghaddam385 and
suever
as code owners
October 16, 2026 19:27
lukeoleson
reviewed
Oct 16, 2026
lukeoleson
approved these changes
Oct 16, 2026
Server status messages were logged at DEBUG and then dropped by parse(), so errors such as "Subscription limit reached for feed" never reached the user and rejected subscriptions failed silently. Log status errors at WARNING. The server can send one error per channel, so identical errors are counted and logged once a second (and on close), e.g. "server error: Subscription limit reached for feed. ... (x1000)". No other behavior changes.
The server also sends statuses like max_connections, max_connections_per_minute, auth_timeout, slow_consumer and force_disconnect, usually right before closing the connection. These were dropped too, so a disconnect looked like the stream just ending. Log any status other than connected/auth_success/success as a warning, including the replies to connecting and authenticating, and flush them when the connection closes.
justinpolygon
force-pushed
the
justin/spt-1644
branch
from
October 16, 2026 19:45
9a01591 to
94768a5
Compare
lukeoleson
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server's status messages on the WebSocket connection were logged at DEBUG and then dropped, so problems were silent: rejected subscriptions (e.g. "Subscription limit reached for feed"), and the reason for a disconnect (
max_connections,slow_consumer,force_disconnect, etc.), which the server sends right before closing. Any status other thanconnected,auth_successorsuccessis now logged at WARNING on theWebSocketClientlogger, one line per burst:No other behavior changes. Tests are included. SPT-1644