Repository navigation
fix ssl: respect SSL_CERT_FILE and REQUESTS_CA_BUNDLE for CA bundle - #1033
Closed
Tyagiquamar wants to merge 1 commit into
Closed
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
Tyagiquamar
requested review from
jbonzo,
justinpolygon,
kschoche,
lukeoleson,
mmoghaddam385 and
suever
as code owners
September 18, 2026 20:35
Contributor
Author
|
Hi team, following up to check if anyone has bandwidth to review this PR when convenient. Thanks! |
Collaborator
|
Hey @Tyagiquamar, yeah I'll take a look. Sorry for the delay. |
alieusaccoh31-alt
approved these changes
Sep 26, 2026
alieusaccoh31-alt
approved these changes
Sep 26, 2026
justinpolygon
added a commit
that referenced
this pull request
Oct 16, 2026
Combines the community PRs that change how the REST client builds its urllib3 pool (#968, #1008, #1026, #1033, #1034). - CA bundle: both clients verify TLS with ca_certs if given, then the SSL_CERT_FILE or REQUESTS_CA_BUNDLE environment variable, then certifi (#998). - RESTClient(maxsize=10): connections kept per host. urllib3 defaults to 1, so threaded clients kept opening new TLS connections. - RESTClient(connection_pool_kw=...): other urllib3 pool options, merged over the defaults (#1009). - RESTClient(proxy=...): explicit proxy URL, with credentials from the URL. Proxy environment variables aren't read, so existing traffic doesn't change route. The WebSocket client already uses the system proxy via websockets. Co-authored-by: SACHU JAMES <142034811+SachuJames@users.noreply.github.com> Co-authored-by: Mohd Quamar Tyagi <104281681+Tyagiquamar@users.noreply.github.com> Co-authored-by: jakobovski-arb <201493996+jakobovski-arb@users.noreply.github.com> Co-authored-by: Roman Zydyk <31843161+romanzdk@users.noreply.github.com> Co-authored-by: Kevin Chiu <2712+kevinchiu@users.noreply.github.com>
justinpolygon
added a commit
that referenced
this pull request
Oct 16, 2026
Adds connection options to the clients, combining #968, #1008, #1026, #1033 and #1034 (contributors are credited as co-authors). - **Custom CA:** `ca_certs=` on `RESTClient` and `WebSocketClient`, defaulting to `SSL_CERT_FILE` / `REQUESTS_CA_BUNDLE`, then certifi. Closes #998. - **Pool size:** `RESTClient(maxsize=10)`. urllib3 defaults to 1 connection per host. - **Pool options:** `RESTClient(connection_pool_kw={...})`, merged over the defaults. Closes #1009. - **Proxy:** `RESTClient(proxy="http://user:pass@host:port")`. Proxy env vars aren't read, so nobody's traffic changes route. The README has a new **Network Configuration** section with examples for each case (custom CA, proxy, threads, other pool options). All new parameters are optional and added at the end of the signatures. The one behavior change: if `SSL_CERT_FILE` or `REQUESTS_CA_BUNDLE` points to a file, it's now used instead of certifi (as `requests` and Python do). If it points to a file that doesn't exist, it's skipped with a warning, so a stale value doesn't break anyone. Verified against the live API through a local TLS-inspecting proxy (mitmproxy with auth): REST and WebSocket connect with the proxy's CA (argument or env var) and fail certificate verification without it; wrong proxy credentials get 407. Under 16 threads, `maxsize=10` opened 16 TLS connections vs 57–70 with urllib3's default. --------- Co-authored-by: SACHU JAMES <142034811+SachuJames@users.noreply.github.com> Co-authored-by: Mohd Quamar Tyagi <104281681+Tyagiquamar@users.noreply.github.com> Co-authored-by: jakobovski-arb <201493996+jakobovski-arb@users.noreply.github.com> Co-authored-by: Roman Zydyk <31843161+romanzdk@users.noreply.github.com> Co-authored-by: Kevin Chiu <2712+kevinchiu@users.noreply.github.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
massive/rest/base.py: new_default_ca_bundle()helper returnsSSL_CERT_FILEif set, elseREQUESTS_CA_BUNDLEif set, elsecertifi.where().BaseClientnow passes it asca_certsto theurllib3.PoolManagerinstead of hardcodedcertifi.where().massive/websocket/__init__.py: thewss://SSLContextloads verify locations from the same helper (removes the now-unused directcertifiimport).test_rest/test_ssl_ca_bundle.pywith 3 tests (precedence, fallback, certifi default) asserting both the helper and the poolconnection_pool_kw.Why
Fixes #998. Behind TLS-inspecting corporate proxies the SDK failed with
CERTIFICATE_VERIFY_FAILEDbecause it always used the bundled certifi CA, ignoring the standard env vars thatrequests,httpx, andurllib3conventions honor.Testing
Docker
python:3.11-bookworm:python -m unittest test_rest.test_ssl_ca_bundle— 3 passed; errors on base (helper absent, env ignored).python -m unittest discover -s test_rest— 42 passed.black --checkon all three touched files — clean (repo uses black per Makefile).