Skip to content

chore: update vendored skills (ponytail-audit,ponytail-review) - #178

Open
marola-pr-bot[bot] wants to merge 1 commit into
mainfrom
chore/skills-update
Open

marola-pr-bot[bot] wants to merge 1 commit into
mainfrom
chore/skills-update

Conversation

@marola-pr-bot

@marola-pr-bot marola-pr-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Summary: re-vendor ponytail-audit,ponytail-review at upstream, skills-vendor update --all --min-age 14.

ponytail-audit: bd6176a -> 1b1a0c5 (2026-10-05)

--- a/ponytail-audit/SKILL.md
+++ b/ponytail-audit/SKILL.md
@@ -19,6 +19,7 @@
 - `delete:` dead code, unused flexibility, speculative feature. Replacement: nothing.
 - `stdlib:` hand-rolled thing the standard library ships. Name the function.
 - `native:` dependency or code doing what the platform already does. Name the feature.
+- `reuse:` equivalent helper, util, or pattern already in this repo. Name the path.
 - `yagni:` abstraction with one implementation, config nobody sets, layer with one caller.
 - `shrink:` same logic, fewer lines. Show the shorter form.
 
@@ -26,11 +27,15 @@
 
 Deps the stdlib or platform already ships, single-implementation interfaces,
 factories with one product, wrappers that only delegate, files exporting one
-thing, dead flags and config, hand-rolled stdlib.
+thing, dead flags and config, hand-rolled stdlib, helpers duplicating an
+equivalent that already lives in this repo.
+Before emitting `delete:`, grep the whole tree for the symbol, including tests,
+fixtures and string or dynamic references.
 
 ## Output
 
-One line per finding, ranked: `<tag> <what to cut>. <replacement>. [path]`.
+One line per finding, numbered and ranked: `<N>. <tag> <what to cut>. <replacement>. [path]`,
+so the user can say "fix 2 and 5".
 End with `net: -<N> lines, -<M> deps possible.` Nothing to cut: `Lean already. Ship.`
 
 ## Boundaries

ponytail-review: bd6176a -> 1b1a0c5 (2026-10-05)

--- a/ponytail-review/SKILL.md
+++ b/ponytail-review/SKILL.md
@@ -15,31 +15,36 @@
 
 ## Format
 
-`L<line>: <tag> <what>. <replacement>.`, or `<file>:L<line>: ...` for
-multi-file diffs.
+`<N>. L<line>: <tag> <what>. <replacement>.`, or `<N>. <file>:L<line>: ...` for
+multi-file diffs. Number findings `1.`, `2.`, ... across the whole report, so the
+user can say "fix 2 and 5".
 
 Tags:
 
 - `delete:` dead code, unused flexibility, speculative feature. Replacement: nothing.
 - `stdlib:` hand-rolled thing the standard library ships. Name the function.
 - `native:` dependency or code doing what the platform already does. Name the feature.
+- `reuse:` equivalent helper, util, or pattern already in this repo. Name the path.
 - `yagni:` abstraction with one implementation, config nobody sets, layer with one caller.
 - `shrink:` same logic, fewer lines. Show the shorter form.
+
 
 ## Examples
 
 ❌ "This EmailValidator class might be more complex than necessary, have you
 considered whether all these validation rules are needed at this stage?"
 
-✅ `L12-38: stdlib: 27-line validator class. "@" in email, 1 line, real validation is the confirmation mail.`
+✅ `1. L12-38: stdlib: 27-line validator class. "@" in email, 1 line, real validation is the confirmation mail.`
 
-✅ `L4: native: moment.js imported for one format call. Intl.DateTimeFormat, 0 deps.`
+✅ `2. L4: native: moment.js imported for one format call. Intl.DateTimeFormat, 0 deps.`
 
-✅ `repo.py:L88: yagni: AbstractRepository with one implementation. Inline it until a second one exists.`
+✅ `3. L18-29: reuse: slugify helper duplicates src/lib/slug.ts slugify. Delete it, import the existing one.`
 
-✅ `L52-71: delete: retry wrapper around an idempotent local call. Nothing replaces it.`
+✅ `4. repo.py:L88: yagni: AbstractRepository with one implementation. Inline it until a second one exists.`
 
-✅ `L30-44: shrink: manual loop builds dict. dict(zip(keys, values)), 1 line.`
+✅ `5. L52-71: delete: retry wrapper around an idempotent local call. Nothing replaces it.`
+
+✅ `6. L30-44: shrink: manual loop builds dict. dict(zip(keys, values)), 1 line.`
 
 ## Scoring

skills-vendor update --all, from the skills-update workflow.

Tested: skills-vendor check
Co-Authored-By: Claude <noreply@anthropic.com>
@marola-pr-bot marola-pr-bot Bot added the skills-update A vendored skill re-pinned by the skills-update workflow (skills.lock) label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skills-update A vendored skill re-pinned by the skills-update workflow (skills.lock)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants