Repository navigation
UI polish: lighter surfaces, framed cards, tab tracks, readable errors, softer focus - #1483
Merged
Merged
Conversation
Panels, cards, headers, inputs, borders and the warm selection chips all move up by the same step (panel #0D0D0D -> #252525), so the UI reads as dark gray instead of near black. Text, accents, channel colors and photo marks keep their values. Hint text stays above 4.5:1 on the panel.
The header inherited QPushButton's rounded bottom corners and had no side outline, so its seam line curled up at both ends and the body's outline started with a corner of its own. The header now carries the outline on all sides with square bottom corners; a collapsed card keeps its rounded ones.
The main tab strip was a full-width band in the card header color, so it merged with the first card's header, while the page tabs sat on the bare panel. Every tab strip now draws the SegmentedChoice track, its tabs drop their own hairline, and the main strip keeps a small gap above the cards.
Error hints used the error red at the small size, under 3:1 on a card. They now take a lighter error_text tier at body size, as the channel colors keep a text tier. error stays for invalid-input edges and the failed-frame badge, where white sits on it.
border_focus drops from #949494 to #7A7A7A: still above 3:1 on the panel and cards, but no longer the brightest edge in the panel.
The Find field sat 8px in from each side while the tab strip and the cards below it run to the panel edge. It now runs edge to edge too; its top and bottom margins still drag the panel.
A warning hint differed from a plain one only by its amber hue, which a user with a color vision deficiency can miss. hint_label now returns a label that keeps a left margin for a warning or an error and paints an alert icon there in the hint's color, centered on the first line; set_hint_kind keeps it in step.
A focused slider handle took a 2px white ring, the brightest edge in the panel, unlike every other control's 1px border_focus edge. A ring on the handle itself cannot keep a gap and fit the 15px track. The slider row now takes the border_focus edge a focused button takes, for Tab focus only, so a click or a drag leaves none behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI polish for the right panel. Each change is a separate commit.
Changes
#0D0D0Dto#252525. Text, accents, channel colors and photo marks keep their values. Hint text is 5.0:1 on the panel.QPushButton's rounded bottom corners and had no side outline. The seam line curled up at both ends, and the body's outline started with its own corner. Now the header has an outline on all sides and square bottom corners. A collapsed card keeps its round corners ([checkable="true"]:!checked, because Qt matches nothing on:checkableor:unchecked).OverflowBardraws theSegmentedChoicetrack,PanelTabdoes not draw its hairline, and the main strip has aspace_smgap above the cards.QLabel[hint="error"]usederrorat the small size, 2.9:1 on a card. A newerror_texttier (#FF5A5A, 4.7:1 on a card) gives error copy the same text tier that the channel colors have. Error hints now show at body size.errorstays for invalid-input edges and the failed-frame badge, which has white on it.hint_labelgives a warning or an error hint an alert icon in its own color, in a left margin, so the hint does not depend on color alone.border_focusedge as a focused button. A ring on the handle cannot have a gap and still fit in the 15px track. A click or a drag shows no edge.border_focuschanges from#949494to#7A7A7A. It is 3.6:1 on the panel and 3.3:1 on a card.Notes
THUMBNAIL_RENDER_VERSIONis not bumped.border_focusfor its highlight ring, so the ring is also softer.Testing
make lintandmake typepass.