Repository navigation
fix(docs): ship the handbook favicon - #235
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handbook pages requested
/docs/favicon.svg, but standalone builds and website exports did not include that file, causing a browser console 404. Ship the existing branded SVG at that path and validate the favicon link and asset during the documentation build.Validation: documentation build checks 153 routes and 27,815 internal links; export regression passes. Actual desktop and 390×844 mobile Chromium navigation, search, themes and menus pass with zero console errors and HTTP 200 for the favicon. Full regression: 4,449 passed, zero failed, 10 explicit opt-in skips; 14 container/plugin/carry tests pass separately. Static, secret-history, security coverage, production dependency audit, DCO and unsigned artifact checks pass.
Independent review is required before integration. Stable promotion remains separate.