Repository navigation
fix: continue streaming past page-local totals - #158
Merged
skupriienko merged 2 commits intoOct 5, 2026
Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Collaborator
|
@Shubham-Padkonde, thank you for your contribution. I'll take a look at it next week |
Collaborator
|
@Shubham-Padkonde, thanks. LGTM. But I'll test whether |
Collaborator
|
v1.9.1 with the fix has been released https://github.com/mailjet/mailjet-apiv3-python/releases/tag/v1.9.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normal REST responses report page-local Count and Total values, so stream() currently stops after the first full page. Continue until a short or empty page instead, preserving the offset and page-size behavior.
Adds four HTTP-level regression cases covering zero/nonzero starting offsets and partial/exact-size final pages. All four fail before the fix; all 212 unit and regression tests pass afterward. Ruff and git diff --check pass. A broader property-test run was interrupted and is not claimed as passing.
API response semantics: https://github.com/mailjet/mailjet-apiv3-php-simple/blob/master/doc/_getting-started.md