Skip to content

fix: continue streaming past page-local totals - #158

Merged
skupriienko merged 2 commits into
mailjet:masterfrom
Shubham-Padkonde:fix/stream-page-totals
Oct 5, 2026
Merged

skupriienko merged 2 commits into
mailjet:masterfrom
Shubham-Padkonde:fix/stream-page-totals

Conversation

@Shubham-Padkonde

Copy link
Copy Markdown

Normal REST responses report page-local Count and Total values, so stream() currently stops after the first full page. Continue until a short or empty page instead, preserving the offset and page-size behavior.

Adds four HTTP-level regression cases covering zero/nonzero starting offsets and partial/exact-size final pages. All four fail before the fix; all 212 unit and regression tests pass afterward. Ruff and git diff --check pass. A broader property-test run was interrupted and is not claimed as passing.

API response semantics: https://github.com/mailjet/mailjet-apiv3-php-simple/blob/master/doc/_getting-started.md

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@skupriienko

skupriienko commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

@Shubham-Padkonde, thank you for your contribution. I'll take a look at it next week

@skupriienko

Copy link
Copy Markdown
Collaborator

@Shubham-Padkonde, thanks.

LGTM. But I'll test whether Limit=1000 should be respected; see https://dev.mailjet.com/docs/api-reference#pagination--sorting. I'll handle it in the next PR with additional tests.

@skupriienko
skupriienko merged commit 0ce7376 into mailjet:master Oct 5, 2026
23 checks passed
@skupriienko skupriienko mentioned this pull request Oct 6, 2026
39 tasks done
@skupriienko

Copy link
Copy Markdown
Collaborator

v1.9.1 with the fix has been released https://github.com/mailjet/mailjet-apiv3-python/releases/tag/v1.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants