Conversation
Plugs the review grid's Massaction\Extended block (the legacy Widget\Grid variant used by review_product_index/pending, distinct from the UI-component Massaction the other grids use) and adds the Auto Translate button to Magento\Review\Block\Adminhtml\Edit, mirroring the ProductAttribute Edit plugin. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…he base one Same-name reuse only needs to hold across modules on the same intercepted type (that's what lets TranslationExtra's plugin override this one) - it doesn't need to match this module's own entry for the base Massaction type. Reusing it there was just confusing on review, not a functional collision (plugin config is keyed by type+name), but distinct names read better. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TranslationExtra's own entityPool declares every id in EntityManager::TYPES unconditionally, so isset() on it is never false from within TranslationExtra itself - the isset() check in AddEntityItems::execute() this was added for could never actually skip anything. The real "adapter unavailable" case (config declares an adapter class that fails to instantiate, e.g. an optional module like Magefan_SecondBlog being disabled) was already handled by getEntityAdapter() returning null, which addEntityIdsToSchedule() already checks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… always label the review fieldset Extra
…rate model now that TranslationPlus extends this class
…act addAutoTranslationFieldset()
…-page-and-block-to-basic 15597-move-store-switcher-for-cms-page-and-block-to-basic
13855-review-translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.