Repository navigation
Conversation
Allow the Dynamic Island hover panel's lower trigger to be disabled independently of the side triggers. The setting defaults to enabled and is persisted under notch-hover.enable-below-trigger; the lower trigger reach slider is gated on the new toggle. Includes geometry, controller, and plugin tests, plus a plugin changelog fragment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
启用下方触发(Enable Lower Trigger) toggle to the Dynamic Island Hover Panel settings so the lower trigger can be disabled independently of the side triggers. Defaults to enabled.When disabled, the panel no longer opens when the pointer moves upward from directly below the Dynamic Island; the lower trigger reach slider is gated on the new toggle.
Changes
NotchHoverPanelGeometry: exclude the below-notch trigger whenenableBelowTriggeris falseNotchHoverPanelController: persistnotch-hover.enable-below-trigger(defaulttrue), refresh the active display inventory on changeNotchHoverPanelPlugin: new settings toggle row, gate the lower reach sliderTesting
NotchHoverPanelGeometryTests: 7 passedNotchHoverPanelControllerTests: 7 passedmake validate-changelog,make validate-localization,git diff --check: passedmake build-plugin PLUGIN=NotchHoverPanel: built successfully