Repository navigation
Conversation
xcv58
marked this pull request as ready for review
November 6, 2026 17:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Screenshot annotation tools currently rely on letter shortcuts, and Spotlight has no tool-selection shortcut. This adds Command-1 through Command-9 in toolbar order while retaining the existing letters.
Related to the screenshot shortcut request in #522. This PR contains only screenshot toolbar work; the compact clipboard view remains in separate PR #526.
Changes
Verification
make test TEST_FILTER=ScreenshotAnnotationEditingTests: 8 passed, 0 failures. Includes numbered mappings, repeat/modifier boundaries, existing aliases, live-text export, native Select All, and marked-text preservation.python3 -m unittest scripts.tests.test_plugin_minimum_host_compatibility: 22 passed.Local validation used Xcode beta on Apple silicon/macOS 27.3. Physical IME interaction, macOS 14, and Intel remain manual checks; marked-text coverage uses native
NSTextView.setMarkedText. The full repository XCTest suite was not rerun for this plugin-only change.UI evidence
Entry point: Screenshot → select a region → press ⌘1–⌘9, or hover an annotation tool to see its shortcut. The final captures show the new Spotlight hint; the annotation toolbar keeps its existing layout.
Before images are the existing screenshots on main. New captures use only synthetic content and an isolated in-memory environment; the fixture captures its own window without reading the desktop or clipboard history.
The native walkthrough posts ⌘1–⌘9 into the fixture's AppKit event loop and captures each selected tool, followed by text entry and ⌘4 committing that text while selecting Arrow. The animation assembles those native window captures; it does not record physical keyboard or global shortcut delivery.
Checklist