Skip to content

Resume request-owned XCTest hosts before waiting for results - #464

Merged
zunda-pixel merged 1 commit into
mainfrom
fix/test-host-launch
Oct 30, 2026
Merged

zunda-pixel merged 1 commit into
mainfrom
fix/test-host-launch

Conversation

@zunda-pixel

Copy link
Copy Markdown
Collaborator

RunSomeTests and RunAllTests wait for test results before request cleanup, so their suspended test hosts never reach the normal RunProject resume path. XCTest also creates the launcher outside the request Task and assigns the tracker's launch session afterward.

Carry request ownership through weak tracker/session identities and resolve it at the launcher's PID callback. Resume only an active test request's stopped, untraced host, using its actual XCTest clone UUID. Normal launches, debugger-selected launches, and cancelled requests keep their lifecycle rules.

Fixes #460.

Validation:

  • 20 focused application-launch, execution-scope, and launch-ownership tests passed, including late session assignment and cancellation guards.
  • Xcode 27.2 / iOS 27.2, fresh packaged native host: both test tools returned one passed test without any manual SIGCONT. Verified again after removing diagnostic logging.
  • Debugger-enabled launch cancellation still removes the observed suspended fixture before the -32800 response, with no survivor through 15 seconds.
  • Owned workspaces and hosts closed without forced termination.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T15:18:49.777804Z 70b10cf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@zunda-pixel
zunda-pixel merged commit 0dc2e1c into main Oct 30, 2026
7 checks passed
@zunda-pixel
zunda-pixel deleted the fix/test-host-launch branch October 30, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RunSomeTests and RunAllTests can leave the XCTest host suspended until manually resumed

1 participant