Repository navigation
chore: P3-38 V23 investigated and dropped; guard the unread-master exit - #188
Merged
Merged
Conversation
…known issue A forced exit with the PTY master open and unread shows macOS state E for about 0.6 s and completes, the same as with a drained master; tcflush before the forced exit changed nothing. Case (v) of check-orphan-exit now guards that the reader exits with the master open and unread. The development guide's known-issues list is empty. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result: V23 could not be reproduced as a hang, so there is no runtime fix
The known issue said a reader exiting with an unread PTY master can sit in macOS state
Eand ignore SIGKILL until the master closes, with the hypothesis that the final close waits for a drain. Measured on macOS (Darwin 25.5.0, v0.1.10 debug build) with the new Rust harness and a few throwaway probes:qprocess::exit), screens 24x80, 120x400, 250x800, 400x1200?Efor about 0.6 s, then gone, master still open and unreadtcflush(OFlush)before the forced exitSo the 0.6 s
Ewindow is the ordinary exit and not a wait for a drain. The two original incidents stay unexplained.What this PR does
check-orphan-exit(default run): master open and unread on a 120x400 screen, session leader killed, the reader must still exit. It guards the property against a future blocking flush on the exit path.dropped, V23 row in the register updated with the measurements, dogfood-log row, development guide "Known issues" now says none open and what to capture if it recurs (the section stays becausereleasing.mdlinks to it).rustixgets thetermiosfeature in the tools crate (for the window size); no change to the shipped binary.Decision for the operator: accept "not reproducible, dropped", or keep P3-38 open as an unexplained report.
Verified:
./scripts/check.sh all(ten PASS cases).🤖 Generated with Claude Code