Repository navigation
chore: P3-41 orphan-exit check in Rust - #187
Merged
Merged
Conversation
…-reader-tools) Replaces scripts/check-orphan-exit.py. rustix pty/setsid/signals, no unsafe: helper modes re-execute the binary so a child can setsid before running the reader. Same nine cases and exit codes, wired into check.sh and CI; python3 is no longer needed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-orphan-exitinwiki-reader-toolsreplacesscripts/check-orphan-exit.py: the same nine V22 cases, CLI ([bin] [root]) and exit codes.unsafe: PTY,setsidand signals go through rustix's safe API.stdonly offerssetsidvia the unsafepre_exec, so the bin re-executes itself in hidden--helpermodes (exec,app,launcher,spawn) that callsetsidthenexecor spawn the reader.scripts/check.shand CI callcargo run -p wiki-reader-tools --bin check-orphan-exit; thepython3requirement is gone. Development guide and audit register updated; P3-41 marked done; dogfood-log row added.rustix(featurepty) to the tools crate; it is already a workspace dependency, andCargo.lockgains one edge.Verified (macOS)
target/debug/wiki-reader: identical PASS set (nine cases)../scripts/check.sh allexits 0; unit test for thepstime parser.ptsname/setsidhere; CI on ubuntu is the check.Next
P3-38 (V23) adds an opt-in reproducer case to this harness.
🤖 Generated with Claude Code