Skip to content

Reuse validated bytes for the complete canonical Todo source basis - #8374

Open
cocolord wants to merge 1 commit into
mainfrom
codex/small-kernel-source-basis-20261108T1601
Open

cocolord wants to merge 1 commit into
mainfrom
codex/small-kernel-source-basis-20261108T1601

Conversation

@cocolord

@cocolord cocolord commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Canonical Todo source binding serializes every native field twice to create an original JSON basis and validate its canonical digest. Reuse the complete, already validated bytes for that basis. JSON decoding preserves the same values; mapping insertion order remains a non-semantic source difference. Digest mismatch fallback, Python scalar facts, request scope, provenance and provider/lease/replay checks retain their existing owners.

Validation on macOS arm64, CPython 3.13.5 and Node 22.22.3:

  • The original implementation passes two mapping-order/scalar characterization cases; the final implementation passes all nine canonical source cases across File/SQLite, including freshness, forged source, outage and large-response cases.
  • A read-only comparison using the same native SQLite fields records four encodings for two original fields and two encodings for the candidate, with complete values and unchanged references in both arms.
  • Four complete 101-Todo CLI lifecycles (checkout/isolated wheel × File/SQLite) preserve sum45, original completion time, four receipts, one debit, restart, refusal/replay and two normal native process exits each. The wheel's runtime source bytes match this commit.
  • Standard premerge passed after restoring missing root TypeScript dev dependencies: six direct checks, ten catalog canaries, eight risk-profile smokes and the public-boundary check. The initial dependency-related semantic smoke failure is retained separately; no source or validation gate was weakened. Staged and committed bilingual checks passed.

This is a serialization refinement. Full marginal-cost/adoption benefit, installed-host and PostgreSQL host/wheel qualification remain open; frozen campaigns are unchanged. GitHub CI, independent exact-head review, merge readiness and maintainer merge authorization remain separate gates.

Integration status: this complete-basis refinement is incorporated into the combined #8372 proposal at head 7e20516, on current main including merged #8360 and #8011. The combined proposal carries source/wheel, real PostgreSQL and packaged browser evidence plus the unresolved report packet-contract validation hold. This component PR remains open and unmerged pending reconciliation; its validation above belongs to the original bd96861 head. Exact-head review, CI/readiness and maintainer merge authority remain required.

Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com>
Co-authored-by: TRAE CLI <traecli@bytedance.com>
@mergify

mergify Bot commented Nov 8, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @cocolord.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Nov 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Mergify: the pull request has merge conflicts with its base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant