Skip to content

fix(russian): use leading-slash paths in HexNovels plugin #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajarsheechatterjee merged 1 commit into from
Oct 28, 2026
Merged

fix(russian): use leading-slash paths in HexNovels plugin #2794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions plugins/russian/hexnovels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,15 @@ class HexNovels implements Plugin.PluginBase {
name = 'HexNovels';
icon = 'src/ru/hexnovels/icon.png';
site = 'https://hexnovels.me';
version = '1.0.0';
version = '1.0.1';

// Paths are site-relative with a leading slash. Library entries saved by
// 1.0.0 lack it, so accept both forms.
private normalizePath(path: string): string {
return '/' + path.replace(this.site, '').replace(/^\/+/, '');
}

resolveUrl = (path: string) => this.site + this.normalizePath(path);

private async fetchHtml(url: string): Promise<string> {
const res = await fetchApi(url);
Expand All @@ -31,10 +39,10 @@ class HexNovels implements Plugin.PluginBase {
const seen = new Set<string>();
$('a[href^="/content/"]').each((_, el) => {
const a = $(el);
const path = a.attr('href')?.substring(1);
const path = a.attr('href');
const name = a.find('p.line-clamp-2').text().trim();
const cover = a.find('img').attr('src');
if (!path || !name || !cover || path.split('/').length !== 2) return;
if (!path || !name || !cover || path.split('/').length !== 3) return;
if (seen.has(path)) return;
seen.add(path);
novels.push({ name, path, cover });
Expand Down Expand Up @@ -62,10 +70,11 @@ class HexNovels implements Plugin.PluginBase {
);
}

async parseNovel(novelPath: string): Promise<Plugin.SourceNovel> {
const html = await this.fetchHtml(`${this.site}/${novelPath}`);
async parseNovel(path: string): Promise<Plugin.SourceNovel> {
const novelPath = this.normalizePath(path);
const html = await this.fetchHtml(this.resolveUrl(novelPath));
const $ = parseHTML(html);
const slug = novelPath.split('/')[1];
const slug = novelPath.split('/')[2];

const novel: Plugin.SourceNovel = {
path: novelPath,
Expand Down Expand Up @@ -94,7 +103,7 @@ class HexNovels implements Plugin.PluginBase {

// All chapters (for every translation branch) are embedded in the chapters page
const chaptersHtml = await this.fetchHtml(
`${this.site}/${novelPath}/chapters`,
`${this.resolveUrl(novelPath)}/chapters`,
);
const unescape = (s: string) => JSON.parse(`"${s}"`) as string;
const re =
Expand Down Expand Up @@ -135,7 +144,7 @@ class HexNovels implements Plugin.PluginBase {
}

async parseChapter(chapterPath: string): Promise<string> {
const $ = parseHTML(await this.fetchHtml(`${this.site}/${chapterPath}`));
const $ = parseHTML(await this.fetchHtml(this.resolveUrl(chapterPath)));
const content = $('.typeset-content').first();
if (!content.length) throw new Error('Chapter content not found');
// Illustration-only chapters load their (encrypted) images client-side
Expand Down
Loading