Skip to content

fix(novelfire): follow JS redirect to mirror when loading chapters - #2763

Merged
rajarsheechatterjee merged 1 commit into
lnreader:masterfrom
Gourab0002:fix/english-novelfire-new-chapters
Oct 24, 2026
Merged

rajarsheechatterjee merged 1 commit into
lnreader:masterfrom
Gourab0002:fix/english-novelfire-new-chapters

Conversation

@Gourab0002

Copy link
Copy Markdown
Contributor

Fixes #2762

What changed

  • plugins/multisrc/novelfire/template.ts (parseChapter): if the fetched page has no #content, look for a window.location.href = "..." redirect in the page scripts and fetch that target instead.
  • plugins/multisrc/novelfire/sources.json: Novel Fire bumped 1.4.4 → 1.4.5.

Why

Novel Fire chapter URLs (https://novelfire.net/book/<novel>/chapter-<n>) now return a 302 to https://readnovel.site/novel/<novel>/chapter-<n>. That page is a "Loading..." stub that forwards with JavaScript to https://novelphoenix.com/novel/<novel>/chapter-<n>?noti=1, where the real chapter (with #content) lives. Webview runs the JS and works; the plugin stopped at the stub and threw "Chapter content container (#content) not found". The chapter list and paths are still correct (checked against listChapterDataAjax and /latest-release-novels).

Verification

  • npm run check:plugin -- "plugins/english/NovelFire[novelfire].ts": before the fix parseChapter ❌ FAIL (#content not found); after the fix all 4 checks ✅ PASS (parseChapter 14597 chars).
  • npm run check:plugin -- "plugins/english/NovelPhoenix[novelfire].ts" (same template): ✅ all pass.
  • Manual: latest chapters, e.g. absolute-beast-dominion/chapter-761, follow the same redirect chain and now load.
  • npx tsc --project tsconfig.production.json --noEmit: OK
  • npx eslint plugins/multisrc/novelfire/template.ts: OK
  • npm run build:full: OK

Risks

  • Depends on the stub page's current window.location.href pattern. If that changes, behaviour falls back to the existing error.
  • The redirect goes through only one extra hop and only when #content is missing, so pages that already work are unaffected.
  • Novel Phoenix shares the template. It doesn't hit this path, and its version is unchanged.

Novel Fire chapter URLs now 302 to readnovel.site, which serves a
"Loading..." page that forwards via window.location.href to
novelphoenix.com. parseChapter now follows that redirect when #content
is missing. Bump Novel Fire to 1.4.5.

Fixes lnreader#2762

Co-Authored-By: Grok Bot (AI agent)
@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Novel Fire now follows one JavaScript redirect when a chapter page lacks #content.

  • Novel Fire chapters can follow a script redirect to their content.

Reviews (1) · Last reviewed commit: "fix(novelfire): follow JS redirect to mi..." · Reviewed by Greptile

@rajarsheechatterjee
rajarsheechatterjee merged commit 9c9767a into lnreader:master Oct 24, 2026
4 checks passed
@Gourab0002
Gourab0002 deleted the fix/english-novelfire-new-chapters branch October 25, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Novel Fire plugin not working

3 participants