Repository navigation
fix(novelfire): follow JS redirect to mirror when loading chapters - #2763
Merged
rajarsheechatterjee merged 1 commit intoOct 24, 2026
Merged
rajarsheechatterjee merged 1 commit into
rajarsheechatterjee merged 1 commit into
Conversation
Novel Fire chapter URLs now 302 to readnovel.site, which serves a "Loading..." page that forwards via window.location.href to novelphoenix.com. parseChapter now follows that redirect when #content is missing. Bump Novel Fire to 1.4.5. Fixes lnreader#2762 Co-Authored-By: Grok Bot (AI agent)
[Medium impact] The PR appears safe to merge. SummaryNovel Fire now follows one JavaScript redirect when a chapter page lacks
Reviews (1) · Last reviewed commit: "fix(novelfire): follow JS redirect to mi..." · Reviewed by Greptile |
rajarsheechatterjee
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2762
What changed
plugins/multisrc/novelfire/template.ts(parseChapter): if the fetched page has no#content, look for awindow.location.href = "..."redirect in the page scripts and fetch that target instead.plugins/multisrc/novelfire/sources.json: Novel Fire bumped 1.4.4 → 1.4.5.Why
Novel Fire chapter URLs (
https://novelfire.net/book/<novel>/chapter-<n>) now return a 302 tohttps://readnovel.site/novel/<novel>/chapter-<n>. That page is a "Loading..." stub that forwards with JavaScript tohttps://novelphoenix.com/novel/<novel>/chapter-<n>?noti=1, where the real chapter (with#content) lives. Webview runs the JS and works; the plugin stopped at the stub and threw "Chapter content container (#content) not found". The chapter list and paths are still correct (checked againstlistChapterDataAjaxand/latest-release-novels).Verification
npm run check:plugin -- "plugins/english/NovelFire[novelfire].ts": before the fixparseChapter❌ FAIL (#content not found); after the fix all 4 checks ✅ PASS (parseChapter 14597 chars).npm run check:plugin -- "plugins/english/NovelPhoenix[novelfire].ts"(same template): ✅ all pass.absolute-beast-dominion/chapter-761, follow the same redirect chain and now load.npx tsc --project tsconfig.production.json --noEmit: OKnpx eslint plugins/multisrc/novelfire/template.ts: OKnpm run build:full: OKRisks
window.location.hrefpattern. If that changes, behaviour falls back to the existing error.#contentis missing, so pages that already work are unaffected.