Repository navigation
Conversation
[Low impact] The PR appears safe to merge, with no actionable issues found. SummaryHexNovels now keeps the leading slash in novel and chapter paths.
No actionable issues were found. The review checked the code; it did not repeat the reported live tests. Reviews (1) · Last reviewed commit: "fix(russian/hexnovels): use leading-slas..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
/content/slug) from the novel list parser. It also definesresolveUrl, so the app's web view builds a full URL instead of dropping the/.normalizePathhelper accepts both the new slash form and the legacy paths saved by 1.0.0.parseNovelandparseChapteruse it, so existing library entries keep loading.🤖 Generated with Claude Code
Risk Assessment
✅ Low: The change is a small, well-bounded fix. Paths now carry a leading slash, a
normalizePathhelper accepts legacy slash-less saved paths, and the version is bumped to 1.0.1. I traced new, legacy and absolute-URL inputs throughresolveUrl,parseNovelandparseChapterand found no wrong result. I did not run the live check.Testing
I bundled the real plugin and ran it against live hexnovels.me. resolveUrl returns https://hexnovels.me/content/<slug> for both '/content/…' and legacy 'content/…' paths, so the missing-slash URL from the issue is gone. popularNovels returned 40 novels with leading-slash paths. parseNovel loaded 440 chapters from both path forms and normalised the novel path to '/content/…'. Real chapters parse from both new and legacy paths: a text chapter returned 10045 chars. The checker's parseChapter FAIL is not caused by the fix: chapter 1 of the first novel is illustration-only, and the plugin deliberately returns a 74-char notice for those. I did not drive the Android app or WebView itself, only the plugin functions that produce the URLs. I removed my temporary files.Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
npm cinpm run check:plugin -- plugins/russian/hexnovels.ts: popularNovels, searchNovels and parseNovel PASS; parseChapter FAIL on an illustration-only chapter 1 (74 chars)Throwaway esbuild-bundled driver run against hexnovels.me: resolveUrl, popularNovels paths, parseNovel with new and legacy paths, parseChapter on new and legacy chapter paths✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.