docs(pm): require an active orchestrator to redeem a winning ticket - #70
Open
rickstaa wants to merge 1 commit into
Open
docs(pm): require an active orchestrator to redeem a winning ticket#70rickstaa wants to merge 1 commit into
rickstaa wants to merge 1 commit into
Conversation
The August 2025 fee overclaim mitigation swapped the registered orchestrator check in updateTranscoderWithFees for an active one, and winningTicketTransfer calls that method. Redemption now reverts for an inactive recipient, or consumes the ticket for nothing when the broadcaster's deposit is 0, neither of which the spec described. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PM spec still describes winning ticket redemption as it behaved before the August 2025 fee overclaim mitigation, which replaced the registered orchestrator check in
BondingManager.updateTranscoderWithFeeswith an active orchestrator check. SincewinningTicketTransfercalls that method, a redemption by an orchestrator that is not active in the current round now reverts, or consumes the ticket without any payment when the broadcaster's deposit is 0. The spec instead said the orchestrator claims the whole deposit and forfeits the remainder.This updates the redemption description and the matching revert condition. The wording was proposed by Sidestream while reviewing livepeer/protocol#663.
The revert condition for a sender whose deposit and reserve are both zero is left as is. livepeer/protocol#657 changes it to require deposit plus remaining reserve to cover the face value, so it needs a follow up once that is deployed.