TPT-4494: Support CFW protocol "ALL" / numeric - #917
Open
psnoch-akamai wants to merge 2 commits into
Open
Conversation
psnoch-akamai
requested review from
zliang-akamai
and removed request for
a team
August 3, 2026 13:36
Contributor
There was a problem hiding this comment.
Pull request overview
Adds integration test coverage for Cloud Firewall rule protocols using the new "ALL" protocol value and numeric protocol values (e.g., "40"), ensuring create and read paths behave as expected via the CLI.
Changes:
- Introduces new session-scoped firewall fixtures that create rule sets using
"ALL"and numeric protocols. - Adds integration tests validating firewall creation output and that
rules-list/version-viewreturn"ALL"as expected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/integration/firewalls/test_firewalls_rules.py | Adds integration tests asserting "ALL" and numeric protocol behavior across create, rules-list, and version-view. |
| tests/integration/firewalls/fixtures.py | Adds fixtures to provision firewalls configured with "ALL" and numeric protocols for the new tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✔️ How to Test
NOTE: This feature is not yet generally available. See TPT-4469 for required test environment information.