Skip to content

TPT-4494: Support CFW protocol "ALL" / numeric - #917

Open
psnoch-akamai wants to merge 2 commits into
linode:devfrom
psnoch-akamai:TPT-4494-linode-cli-support-cfw-protocol-all-numeric
Open

TPT-4494: Support CFW protocol "ALL" / numeric#917
psnoch-akamai wants to merge 2 commits into
linode:devfrom
psnoch-akamai:TPT-4494-linode-cli-support-cfw-protocol-all-numeric

Conversation

@psnoch-akamai

Copy link
Copy Markdown
Contributor

✔️ How to Test

NOTE: This feature is not yet generally available. See TPT-4469 for required test environment information.

make test-int TEST_ARGS="-k test_create_firewall_protocol_numeric_and_all"
make test-int TEST_ARGS="-k test_firewall_protocol_all_get_rules_list"
make test-int TEST_ARGS="-k test_firewall_protocol_all_get_version_view"

@psnoch-akamai
psnoch-akamai requested review from a team as code owners August 3, 2026 13:36
@psnoch-akamai
psnoch-akamai requested review from zliang-akamai and removed request for a team August 3, 2026 13:36
@psnoch-akamai psnoch-akamai added testing for updates to the testing suite in the changelog. do-not-merge PRs that should not be merged until the commented issue is resolved labels Aug 3, 2026
@psnoch-akamai
psnoch-akamai requested review from mawilk90 and removed request for a team August 3, 2026 13:36
@psnoch-akamai psnoch-akamai changed the title Tpt 4494: linode-cli: Support CFW protocol "ALL" / numeric Tpt 4494: Support CFW protocol "ALL" / numeric Aug 3, 2026
@psnoch-akamai psnoch-akamai changed the title Tpt 4494: Support CFW protocol "ALL" / numeric TPT-4494: Support CFW protocol "ALL" / numeric Aug 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds integration test coverage for Cloud Firewall rule protocols using the new "ALL" protocol value and numeric protocol values (e.g., "40"), ensuring create and read paths behave as expected via the CLI.

Changes:

  • Introduces new session-scoped firewall fixtures that create rule sets using "ALL" and numeric protocols.
  • Adds integration tests validating firewall creation output and that rules-list / version-view return "ALL" as expected.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/integration/firewalls/test_firewalls_rules.py Adds integration tests asserting "ALL" and numeric protocol behavior across create, rules-list, and version-view.
tests/integration/firewalls/fixtures.py Adds fixtures to provision firewalls configured with "ALL" and numeric protocols for the new tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge PRs that should not be merged until the commented issue is resolved testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants