Skip to content

some npm version updates - #428

Merged
richardiphillips merged 2 commits into
mainfrom
updates34
Sep 3, 2026
Merged

some npm version updates#428
richardiphillips merged 2 commits into
mainfrom
updates34

Conversation

@richardiphillips

@richardiphillips richardiphillips commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

remove mui styles
remove direct webpack deps

remove mui styles
remove webpack
@richardiphillips
richardiphillips requested review from a team and a lite review from Copilot September 3, 2026 10:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The resolutions field is ineffective under npm (npm ci), so the intended dependency pinning should be converted to npm overrides (or otherwise corrected) before merging.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the library’s dependency set (and publishes a new major version), removing some previously pinned build tooling while bumping several React/MUI/testing/storybook packages.

Changes:

  • Bump package version to 34.0.0.
  • Remove direct webpack-related pins/dependencies (e.g., webpack resolution and loaders) while updating Storybook and other dev tooling versions.
  • Remove @mui/styles and update MUI/React/React Router versions in peer + dev dependencies.
File summaries
File Description
package.json Version bump and dependency/peerDependency updates, including removal of @mui/styles and direct webpack-related deps/pins.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json Outdated
Comment on lines 34 to 36
"resolutions": {
"**/@emotion/styled": "11.0.0",
"webpack": "5.88.2"
"**/@emotion/styled": "11.0.0"
},
Comment thread package.json
Copilot AI review requested due to automatic review settings September 3, 2026 10:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are confined to dependency/version declarations and appear internally consistent with the current build/test scripts and tooling setup.

Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@richardiphillips
richardiphillips merged commit 4de6e97 into main Sep 3, 2026
1 check passed
@richardiphillips
richardiphillips deleted the updates34 branch September 3, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants