Handle ForbiddenResult and add Disposition to StreamCopyingResultHandler - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the stream result handling pipeline to (1) correctly map ForbiddenResult<StreamResponse> to HTTP 403 responses and (2) allow callers to control Content-Disposition (inline vs attachment) when returning streamed content, with corresponding version/changelog updates.
Changes:
- Add
DispositiontoStreamResponseand use it when setting theContent-Dispositionheader. - Handle
ForbiddenResult<StreamResponse>explicitly inStreamCopyingResultHandler(return 403 and optional message body). - Add focused unit tests and bump package version/changelog accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/WhenCopyingStreamResult.cs | Adds tests for stream copying, content disposition behavior, and 403 handling. |
| src/Linn.Common.Service.csproj | Bumps library version to 3.2.0. |
| src/Handlers/StreamResponse.cs | Introduces Disposition property (default inline). |
| src/Handlers/StreamCopyingResultHandler.cs | Uses Disposition in Content-Disposition and adds 403 handling for forbidden results. |
| Linn.Common.Service.sln | Updates solution metadata (VS version / SolutionGuid). |
| CHANGELOG.md | Documents the 3.2.0 changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+43
to
+47
| var disposition = string.IsNullOrEmpty(success.Data.Disposition) | ||
| ? "inline" | ||
| : success.Data.Disposition; | ||
| res.Headers["Content-Disposition"] = | ||
| $"inline; filename=\"{success.Data.FileName}\""; | ||
| } | ||
| $"{disposition}; filename=\"{success.Data.FileName}\""; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.