Repository navigation
android: launch configured default digital assistant on stem long-press (#868) - #886
Open
duongynhi000005-oss wants to merge 1 commit into
Conversation
…tion (librepods-org#868) Resolve the active default assistant package from Settings.Secure ("assistant" / "voice_interaction_service") and dispatch ACTION_VOICE_COMMAND / ACTION_ASSIST scoped to that package first, falling back cleanly to unscoped ACTION_ASSIST and ACTION_VOICE_COMMAND on ActivityNotFoundException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #868
Problem
executeStemAction()previously dispatched an unscopedIntent(Intent.ACTION_VOICE_COMMAND)forStemAction.DIGITAL_ASSISTANT. Because third-party default digital assistants (such as Grok Bot, ChatGPT, Perplexity, etc.) typically register forIntent.ACTION_ASSISTrather thanIntent.ACTION_VOICE_COMMAND, an unscopedACTION_VOICE_COMMANDfalls through to the Google app (which redirects to the Android Default digital assistant app settings screen when it is not the active default) or to Bixby on Samsung devices.Solution
Settings.Secure("assistant"/"voice_interaction_service", both@Readableon Android 13+).Intent.ACTION_VOICE_COMMANDandIntent.ACTION_ASSISTscoped viasetPackage(defaultAssistantPackage)first:ACTION_ASSIST.Intent.ACTION_ASSIST->Intent.ACTION_VOICE_COMMANDcatchingActivityNotFoundException/SecurityException.