Conversation
bjarn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add typed webhook Basic Auth credentials and the safe has_basic_auth response flag. Preserve omitted, set and explicit-null request states. Keep empty passwords and credential whitespace. API requests still use Bearer authentication; Basic Auth applies to webhook delivery.
Source
Fresh strict export from monorepo main bfabb708ead47ee31922a7ae772e3d6376ac2ea4, after backend PR https://github.com/lettermint/lettermint/pull/2578. Splitter tests: 7 pass, none skipped. Both split documents match the checked-in docs. No OpenAPI document is included in this repository.
Sending SHA-256: c2aafb6d48a2572e688224629076748322f9c257394f18fe8879efb3f05059cb
Team SHA-256: e385c5f9b330633e943729ecb0e1b93fca96e84fecb2f111b3af8f0bafa0cc75
Verification
85 tests pass; Ruff lint/format and mypy source checks pass. Sync and async credential-state tests and a mocked Sandbox 403 test pass.
Existing scheduling, cursor, raw-pong and signed webhook tests remain in the suite. Existing public methods and compatibility helpers are retained.
No merge, deployment or package publication was performed.
Python 3.9 regression: the new nullable credential hint uses Optional, and the test resolves each new field without evaluating unrelated older union hints. All 85 tests pass on Python 3.9 and the current local interpreter. The installed mypy warns that its configured Python 3.9 target is no longer supported; source checking still passes.
Intentional typed-fixture migration
The API requires has_basic_auth in webhook detail, list and secret responses. Three old-caller mypy tests prove that fixtures without this field fail checking, and that adding has_basic_auth: False or True restores source compatibility. The wire read flag must stay required. Python has no JVM-style binary interface for these TypedDict additions.