Skip to content

fix: switch the filesystem disk to s3 when RustFS is wired - #98

Merged
geodro merged 1 commit into
mainfrom
fix/rustfs-filesystem-disk
Oct 8, 2026
Merged

geodro merged 1 commit into
mainfrom
fix/rustfs-filesystem-disk

Conversation

@geodro

@geodro geodro commented Oct 8, 2026

Copy link
Copy Markdown
Member

Picking RustFS for a Laravel site, from setup or from the suggested service card on the dashboard, wired the AWS keys into .env but left FILESYSTEM_DISK on local. The app kept writing to the local disk and the bucket lerd had just created stayed empty. The preset does carry FILESYSTEM_DISK=s3, but a framework that maps a service gets only its own vars, and Laravel's mapping never listed the disk.

Laravel's rustfs mapping now writes the disk key too. Laravel 9 and later read FILESYSTEM_DISK, 6 to 8 read FILESYSTEM_DRIVER, so each version gets the key it actually reads, and the detect rule on 6 to 8 now looks at that key as well.

Statamic, Winter and Lumen run on Laravel and read the same AWS keys, yet they had no rustfs mapping at all and only got the preset's keys through the fallback. They now map it the same way, with the disk key matched to the Laravel version underneath. Statamic 3 spans Laravel 6 to 10, so it writes both keys. Winter 1.1 hardcodes the local disk, so only 1.2 actually switches.

Symfony stays as it is. S3 there goes through a bundle whose env names the app chooses, so there is no standard key to map.

Adding RustFS to a Laravel site wired the AWS keys but left FILESYSTEM_DISK on local, so uploads kept landing on the local disk and the bucket sat unused. Laravel's rustfs mapping now writes the disk key as well, FILESYSTEM_DISK on 9 and later and FILESYSTEM_DRIVER on 6 to 8, which is the key those versions read, and the detect rule on 6 to 8 follows the same key.

Statamic, Winter and Lumen run on Laravel and read the same AWS keys, but they had no rustfs mapping and only got the preset's keys through the fallback. They now map it the same way, with the disk key matching the Laravel version each one runs on. Statamic 3 spans Laravel 6 to 10, so it writes both keys.
@geodro
geodro requested a review from a team as a code owner October 8, 2026 17:36
@geodro
geodro merged commit 8a71087 into main Oct 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant