Repository navigation
fix: Bump launchdarkly-server-sdk-evaluation to 2.2.2 - #209
Merged
Merged
Conversation
2.2.2 fixes global private attribute redaction when an attribute and one of its nested properties are both configured as private (for example "/address" and "/address/street"). Depending on HashSet iteration order, the parent could be dropped, so its other properties were sent in analytics events and redactedAttributes listed only the child.
kinyoklion
marked this pull request as ready for review
October 19, 2026 22:57
beekld
approved these changes
Oct 19, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Oct 20, 2026
🤖 I have created a release *beep* *boop* --- ## [3.3.2](3.3.1...3.3.2) (2026-10-20) ### Bug Fixes * Bump launchdarkly-server-sdk-evaluation to 2.2.2 ([#209](#209)) ([e949e5e](e949e5e)) * Ignore FDv2 objects with unrecognized kinds ([#207](#207)) ([3d22f1b](3d22f1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > **Release 3.3.2** — bumps `launchdarkly-server-sdk` from **3.3.1** to **3.3.2** via Release Please: `.release-please-manifest.json`, `launchdarkly-server-sdk/Cargo.toml`, and a new **3.3.2** section in `CHANGELOG.md`. > > The changelog documents two patch-level fixes already on `main`: upgrading **`launchdarkly-server-sdk-evaluation`** to **2.2.2**, and **ignoring FDv2 objects with unrecognized kinds** so newer wire payloads do not break ingestion. This PR does not include additional source changes beyond the version and release notes. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e946289. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Describe the solution you've provided
Raises the
launchdarkly-server-sdk-evaluationrequirement from 2.2.1 to 2.2.2 so the minimum version includes the private-attribute redaction fix.The bug: suppose the global private attributes contain both an attribute and one of its nested properties, such as
/addressand/address/street. If the child reference was processed first, the parent reference was dropped. Analytics events then includedaddresswith onlystreetremoved, and_meta.redactedAttributeslisted only/address/street. Private attributes are stored in aHashSet, so whether this happened depended on iteration order. Sibling references (such as/address/cityand/address/street) and per-context private attributes were not affected.This SDK serializes event contexts through the evaluation crate's
ContextAttributes, so the version bump is the whole fix. No public API changed between 2.2.1 and 2.2.2.Describe alternatives you've considered
None.
Additional context
The regression test is in the evaluation crate (
global_private_parent_is_redacted_when_a_child_is_also_private). 2.2.2 also raises that crate's MSRV to 1.97, which matches this SDK's current MSRV.Local checks on Rust 1.97 (aarch64 Linux):
cargo fmt --check, pluscargo test,cargo clippy -- -D warnings, and the contract-test service build for each of the seven CI feature sets. All pass. I did not run the contract test harness or the musl build locally.As a one-off check that was not committed, I serialized 64 inline events through
BaseEventwith global private attributes{/address, /address/street}. With 2.2.1,addressleaked in 31 of 64. With 2.2.2, none leaked, and every event listed/addressinredactedAttributes.Note
Overview
Bumps
launchdarkly-server-sdk-evaluationfrom 2.2.1 to 2.2.2 so event context serialization picks up a fix for global private-attribute redaction when both a parent path and a nested child are marked private (e.g./addressand/address/street).Previously, iteration order over a
HashSetcould drop the parent reference and leak partialaddressdata in analytics events with incomplete_meta.redactedAttributes. This SDK routes redacted contexts through the evaluation crate’sContextAttributes(e.g.redacted_context_attributeson events), so the version bump is the full change—no local code or public API changes in this repo.Reviewed by Cursor Bugbot for commit cdf5853. Bugbot is set up for automated code reviews on this repo. Configure here.