Make the GitHub CI actually run - #3
Merged
Merged
Conversation
patkenneally
force-pushed
the
fix/github-actions-modernize
branch
from
August 24, 2026 23:09
73a15a8 to
ac83e8e
Compare
patkenneally
force-pushed
the
fix/github-actions-modernize
branch
from
August 24, 2026 23:48
ac83e8e to
cb950ff
Compare
patkenneally
force-pushed
the
fix/github-actions-modernize
branch
from
August 25, 2026 00:10
765b4fa to
d9b5edf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI here has never worked. Every job died in
actions/checkoutbefore any compiler ran:Jobs ran in
container: ubuntu:18.04(glibc 2.27) and GitHub now forces JS actions onto Node 24, which needs 2.28+. Upstream gets away with that image because GitLab runs it on self-hosted runners. Fix is mostly "stop using the container": smoketests now run onubuntu-24.04with gcc-13 (C++03 and C++11) and clang-18 (C++11 only - Eigen 3.4'smetatest doesn't compile under clang in C++03).Also deleted the 16-job test matrix -
buildtestsis hours per job times 16, which hosted runners can't do..github/workflows/README.mdrecords why and how to run the full suite locally. And.gitignore's*build*was silently swallowing.github/workflows/build.yml, so that's negated now.