Repository navigation
Require complete Web and native packaged CI acceptance - #13
Merged
Merged
Conversation
Build a test-signed registry fixture from the immutable Plugins candidate and run the complete Web suite against it before aggregate validation. Require independent native macOS and Linux package builds, cold readiness and URL handoff smoke tests, and retained candidate artifacts. Consume Terminal Host through its public npm Deno and native metadata exports so clean checkouts need no sibling source. Validation: root check 18/18, unit 18/18 and build 10/10 tasks; desktop 218 passes with one existing skip; fresh macOS package and cold smoke; complete Web 10/10; release-tool 67/67 with the pinned CI environment; spec, ownership, metadata, release intent, formatting and actionlint pass. Production publication, signing and deployment stay separately gated.
Verify the exact Plugins checkout and export its commit inside the fixture build shell, since GitHub retains its default workflow SHA over step-level environment declarations. Correct macOS Deno output naming to avoid .app.app bundles and select the configured or PATH runtime consistently. Preserve error messages alongside WebKit stacks and include the failed startup phase in packaged smoke output; retain native candidates on failure. Validation: three focused regressions change from one failure each to one pass; root check 18/18, unit 18/18 and build 10/10 tasks; desktop 219 passes with one existing skip; release-tool 68/68; spec, ownership, metadata, release intent, formatting and actionlint pass. A fresh Deno 2.9.7 macOS package passes cold smoke. Linux startup remains under CI diagnosis; production gates remain closed.
Native runners build and install the separately distributed controller CLI from exact public release source 0082a115, pass its isolated executable path to packaged smoke, and retain its manifest. The SDK package alone does not install that service executable. Run complete Web acceptance on native Ubuntu with Chromium and Docker, building the candidate server image before the suite. Exclude candidate areas from the server image context. Validation: two missing-prerequisite regressions change from failures to passes; 70 release-tool and 23 workflow/transport tests; spec, ownership, metadata, release intent, formatting and actionlint. The released controller source passes 194 Node tests and seven runtime-install tests; Notes macOS cold smoke passes with its isolated CLI. A fresh server image passes the exact server-host test and all ten Web cases. Native GitHub qualification remains required.
Pin native acceptance to the source-owned controller repair so Linux can materialize pnpm-linked dependencies without GNU tar hard-link failures. Seed the server browser fixture through stdin into a mode-0600 Docker volume owned by the service user, preserving browser assertions and startup deadlines. Record the canonical contracts and source qualification evidence. Validation: exact server acceptance 1/1, complete Web 10/10, fresh macOS packaged smoke with controller 11c70f, release tools 70/70, workflow/fixture 23/23, Web check, specification/ownership/metadata gates, release intent, formatting and actionlint. Controller source CI and Linux install proof pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR CI lacked complete Web and native packaged acceptance. Require the full Web suite and independent macOS/Linux package builds and cold smoke before the aggregate can succeed. Failed, cancelled or skipped lanes block validation; native candidates remain available after failures.
Web acceptance consumes a test-signed 12-plugin fixture from immutable Plugins candidate
61bf175f21d91f17e06a071bdaadbaf5d87645a1(lapismd/lapis-plugins#6). The build verifies its checkout and exports source provenance in the shell. Ephemeral fixture keys stay outside production trust. Native Ubuntu provisions Chromium and Docker and builds the candidate server image. Server acceptance seeds its bootstrap credential through stdin into a private mode-0600 volume owned by the container service user and mounts it read-only, preserving all assertions and deadlines.Native runners provision the separate controller CLI from exact candidate
11c70f4390190b8f9e1bc0d06ed349df5c142754(lapismd/ai-controller#1), based on released 0.1.0 source. Its owning packaging repair materializes npm inventory files independently so pnpm hard links cannot break GNU tar on Linux. The owning installer writes the isolated runtime snapshot and its retained manifest. Desktop packaging uses Terminal Host's public npm exports, passes an extension-free macOS output name to Deno, and selects the configured or PATH runtime. Startup diagnostics preserve messages omitted by WebKit stacks.Validation: root check 18/18 tasks, unit 18/18 tasks, build 10/10 tasks; desktop 219 tests plus one existing skip; fresh Deno 2.9.7 macOS package and cold smoke using the repaired controller snapshot; exact server-host 1/1 and complete Web 10/10; release tools 70/70, workflow/fixture 23/23, spec/ownership/metadata, Web check, release intent, formatting and actionlint. Controller source CI is green with 195 Node tests, seven runtime-install tests, full CLI build and verified Linux installation. Plugins source CI is green with all nine jobs and 177 interaction/accessibility cases.
Notes CI 38460618229 executed all jobs and passed macOS packaged smoke plus all 243 interaction/accessibility cases. Its Linux controller staging and Web secret ownership failures are repaired here; fresh full GitHub qualification is required. Production publication, registry signing, dispatch and deployment remain separately gated.