Fix rendering of boolean attributes - #2
Merged
Merged
Conversation
alysbrooks
reviewed
Mar 17, 2023
alysbrooks
left a comment
alysbrooks
left a comment
Member
There was a problem hiding this comment.
Looks good, just one small change.
|
|
||
| ## Changed | ||
|
|
||
| # 0.0.5 |
Member
There was a problem hiding this comment.
Suggested change
| # 0.0.5 |
You don't need to manually add the version string, our release tooling does that automatically.
Contributor
Author
There was a problem hiding this comment.
Thanks, I thought I was doing it wrong. I think I've got it right this time (I had "## Fixed" twice after removing the version string so also removed that)?
Member
There was a problem hiding this comment.
All you need to do is add a bullet with your changes, so it's correct now.
alysbrooks
reviewed
Mar 17, 2023
|
|
||
| ## Fixed | ||
|
|
||
| - Correctly handle boolean attributes (false values are removed) |
Member
There was a problem hiding this comment.
Suggested change
| - Correctly handle boolean attributes (false values are removed) | |
| - Correctly handle boolean attributes (false values are removed rather than being set to "false") |
Tiny suggestion.
Contributor
Author
There was a problem hiding this comment.
Good call - done.
When boolean attributes are false they should be removed as the presence of attribute=false is interpreted as the attribute being set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When boolean attributes are false they should
be removed as the presence of attribute=false
is interpreted as the attribute being set.
There is a PR against enlive that does exactly the same thing but it has never been merged: cgrand/enlive#107