Repository navigation
fix: prototype-polluting function - #500
Closed
julio-lopez wants to merge 1 commit into
Closed
julio-lopez wants to merge 1 commit into
julio-lopez wants to merge 1 commit into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
julio-lopez
changed the title
julio-lopez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/kopia/htmlui/security/code-scanning/3
The best fix is to harden deep-path traversal/assignment by rejecting unsafe path segments before any read/write happens. In general, for deep assignment helpers, you should block prototype-pollution gadget keys (
__proto__,constructor,prototype) for every segment in the path and avoid traversing into those keys.In
src/utils/deepstate.js, updatesetDeepStatePropertyto validate eachpartduring traversal and also validate the final segment before assignment. If any segment is unsafe, return early (no state mutation). This preserves existing behavior for valid keys and prevents pollution through both intermediate and terminal path components. No new imports are needed; add a local denylist check inside the function.Suggested fixes powered by Copilot Autofix. Review carefully before merging.