Repository navigation
docs: link the Go badge to go.mod on GitHub - #28
Merged
Merged
Conversation
The relative go.mod link broke in release archives, which bundle the READMEs but not go.mod. Use the absolute URL like the other badges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Go version badge in all four READMEs used a relative
go.modlink. Release archives include the READMEs but notgo.mod, so the link has been broken in every archive since v0.5.0. It now points tohttps://github.com/kongesque/line-cli/blob/main/go.mod, the same way the other badges use full GitHub URLs.Found while inspecting the v0.6.0 packaging rehearsal. This should merge before tagging
v0.6.0, and the tag should go on the resulting merge commit.Validation
./build.sh,go test -race ./internal/... ./cmd/line ./pkg/line/... ./pkg/e2ee,goimports,go vet,staticcheck, andgit diff --checkall pass.