Repository navigation
Report missing Letter Sealing keys after QR approval - #26
Merged
Merged
Conversation
QR final login can issue a token without usable key metadata, and the CLI then reported only a generic local setup failure. Report that case directly, with next steps and a diagnostic of fixed field states and a count, so it carries no server text. The session is still not saved, and NoE2EE is never inferred. Refs #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qrCodeLoginV2metadata:metaDataand each key field as absent, null, empty, or present,errorCodeas absent, SUCCESS, or other, and a count of unrecognized fields. It holds fixed words and a count only, never server text.Encryption behavior is unchanged: the session is still not saved,
NoE2EEis never inferred, and final login is never retried.Refs #25. This does not fix the reported login failure. The root cause is unknown, so the issue should stay open until the new diagnostic and Chrome's behavior for a missing
keyIdare known.Validation
gofmt,go vet,go build ./cmd/line, andgo test -race ./internal/... ./cmd/line ./pkg/line/... ./pkg/e2ee.goimports,staticcheck, and the./pkgand./pkg/ltsmsuites. No imports changed, and that code is untouched.