Skip to content

Fix potentially vulnerable cloned function - #886

Open
npt-1707 wants to merge 1 commit into
kkroening:masterfrom
npt-1707:fix_CVE-2015-9251
Open

Fix potentially vulnerable cloned function#886
npt-1707 wants to merge 1 commit into
kkroening:masterfrom
npt-1707:fix_CVE-2015-9251

Conversation

@npt-1707

Copy link
Copy Markdown

Hi,

Our tool identified a potential vulnerability in a clone function in doc/html/_static/jquery-3.2.1.js sourced from jquery/jquery. This issue, originally reported in CVE-2015-9251, was resolved in the repository via this commit jquery/jquery@2546bb3.

This PR suggests applying the corresponding patch to fix the vulnerabilities in this codebase.

Please review at your convenience. Thank you!

@fallenmi fallenmi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch does not affect any JavaScript loaded by the generated documentation. All four committed HTML pages reference _static/jquery.js; none references _static/jquery-3.2.1.js, which is the only file changed here. On exact head 7e7e2f424d9a6deaed4b28d8854d9705fe1135c4, the loaded _static/jquery.js has the same SHA-256 as base (87083882cc6015984eb0411a99d3981817f5dc5c90ba24f0940420c5548d82de), so runtime behavior is byte-for-byte unchanged.

The active minified bundle also already contains the gh-2432 cross-domain auto-execution mitigation, and the base unminified jQuery 3.2.1 copy already has the corresponding s.contents.script = false prefilter. In addition, doc/Makefile removes and regenerates doc/html, so this direct generated-file edit will be discarded by the next documentation build.

Please do not merge this as a security fix in its current form. If a dependency refresh is still desired, update the Sphinx/jQuery source or build dependency, regenerate the artifacts including the actually loaded _static/jquery.js, and add a reachability/regression check showing that the loaded asset changes and preserves intended explicit script requests.

My deterministic base/head oracle parsed every committed HTML script tag and reported patched_asset_references=0, active_bundle_unchanged=true, and base_already_contains_gh2432_mitigation=true. The full available Python suite was identical on base and head (68 passed, the same 2 unrelated current-FFmpeg/ffprobe failures).

AI disclosure: I used OpenAI Codex to help inspect the diff and documentation build path, construct and run the exact base/head reachability oracle, and draft this review. I manually verified the references, hashes, existing mitigation, test results, and conclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants