Repository navigation
Preserve oversized v9 reports and retry immutable fragments - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When BugHub returned HTTP 413, the v9 reporter moved the full report to dead-letter and stopped retrying it. Keep the original bytes and ACK bundle pending, and use the receiver’s fragment endpoint only after an explicit split-supported response.
Persist fixed fragment IDs and byte boundaries before sending. Retry the same manifest after partial failures or lost responses, and acknowledge runtime records only after a matching report ID and full SHA-256 completion. Keep v5–v8 and controlled one-observation behavior unchanged. The v9 queue admits a 128 MiB report plus its base64 ACK envelope and keeps unaccepted reports retryable.
Validation: focused v9 fragment/ACK/retry tests, v5/v8 contracts, cancelled one-observation guard, JavaScript syntax, current-document checks and diff checks passed locally. Normal three-OS CI remains required. Receiver deployment readiness and normal host rollout/receipts are separate pending steps.
Historical 03:17 reports were no longer present in the affected hosts’ retained state; their sizes and per-product growth remain unknown.