Repository navigation
Install a library or profile skill through its owning plugin when the fetched source marketplace supplies it - #48
Merged
Conversation
… fetched source marketplace supplies every named skill, else keep npx skills.
…, and cover a skill whose plugin alone is refused for an escaping symlink.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bead skillz-5aw.18.4. When Applier::plan meets a missing Spec::Skill it fetches the source once per distinct source through clone::with_source. Each agent whose marketplace supplies every named skill, with none refused for a symlink that leaves the source, installs the owning plugin through plan_add_source; every other agent, and every agent when the fetch or tree read fails, keeps npx skills add. install --skill and the apply path share one rule (supplying_plugins). Applier gains a runner field; a dry run now clones to plan. Decisions: partial supply sends the whole entry to npx; mixed agents split; a plan_add_source refusal sends that agent to npx. Not in this PR: trust gating of native plugin hooks/MCP (5aw.5), a natively installed skill still reading as missing (5aw.18.6), refusing escaping-symlink skills on the npx path (5aw.22). Review: independent reviewer PASS, hall-monitor clean after one fix round, gate green, line coverage 92.79%.