Skip to content

Install a library or profile skill through its owning plugin when the fetched source marketplace supplies it - #48

Merged
archae0pteryx merged 2 commits into
mainfrom
feat/library-skill-native
Oct 28, 2026
Merged

archae0pteryx merged 2 commits into
mainfrom
feat/library-skill-native

Conversation

@archae0pteryx

Copy link
Copy Markdown
Contributor

Bead skillz-5aw.18.4. When Applier::plan meets a missing Spec::Skill it fetches the source once per distinct source through clone::with_source. Each agent whose marketplace supplies every named skill, with none refused for a symlink that leaves the source, installs the owning plugin through plan_add_source; every other agent, and every agent when the fetch or tree read fails, keeps npx skills add. install --skill and the apply path share one rule (supplying_plugins). Applier gains a runner field; a dry run now clones to plan. Decisions: partial supply sends the whole entry to npx; mixed agents split; a plan_add_source refusal sends that agent to npx. Not in this PR: trust gating of native plugin hooks/MCP (5aw.5), a natively installed skill still reading as missing (5aw.18.6), refusing escaping-symlink skills on the npx path (5aw.22). Review: independent reviewer PASS, hall-monitor clean after one fix round, gate green, line coverage 92.79%.

… fetched source marketplace supplies every named skill, else keep npx skills.
…, and cover a skill whose plugin alone is refused for an escaping symlink.
@archae0pteryx archae0pteryx added the needs-review Ask CodeRabbit to review this PR (it reviews only labelled PRs, once per label) label Oct 28, 2026
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0be3028 and 705e5a3.

Files selected for processing: 11
  • DESIGN.md
  • README.md
  • src/app/apply/each_tests.rs
  • src/app/apply/mod.rs
  • src/app/apply/plan.rs
  • src/app/apply/tests.rs
  • src/app/install/mod.rs
  • src/cli/session/change.rs
  • src/cli/session/change/scope_tests.rs
  • src/cli/session/change/selection_tests.rs
  • tests/profile.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@archae0pteryx
archae0pteryx merged commit c850562 into main Oct 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Ask CodeRabbit to review this PR (it reviews only labelled PRs, once per label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant