[archae0pteryx]

Lane A2 of skillz-5aw.12 (fetch safety); the git transport half merged in #45.

install no longer offers or installs a skill, or a local plugin, when a symlink in its tree resolves outside the source: directly, through a chain, as a hop out and back, or dangling. Fetched clones and local directories go through the same check.

• New Containment (crates/skillz-harness/src/contained.rs) resolves each link hop by hop, memoised by canonical directory, with a visited set so link loops finish.
• A local plugin with one escaping skill, or whose own source path is an escaping or dangling link, is refused whole: it is listed in the new PluginOffer.refused and shown as skipped. Remote plugins are never scanned.
• Skills found for the npx skills route are judged per directory; a name carried by any escaping directory is refused.
• A marketplace that offers no plugins now falls through to npx skills instead of opening an empty picker.

Clean sibling skills of a refused plugin can still be installed as loose skills; they carry no escaping links. Profile and library applies are not scanned (they go straight to npx/claude/codex).

Reviewed locally by a fresh reviewer over three rounds (PASS) and a rules check (no blocking rows).

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: killallgit/skillz
• Branch: fix/fetch-symlinks
• File: .coderabbit.yaml
• Commit: 80fa8df
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 96ba627c-78cd-42fe-8528-1c754fda9074

Commits

Reviewing files that changed from the base of the PR and between a8bbb54 and 80fa8df.

Files selected for processing: 11

• crates/skillz-harness/src/agent_skills/mod.rs
• crates/skillz-harness/src/agents/claude/marketplace.rs
• crates/skillz-harness/src/agents/codex/plugins.rs
• crates/skillz-harness/src/agents/mod.rs
• crates/skillz-harness/src/agents/plugin.rs
• crates/skillz-harness/src/contained.rs
• crates/skillz-harness/src/lib.rs
• crates/skillz-harness/src/test_support.rs
• src/app/install/mod.rs
• src/app/install/skills.rs
• tests/conformance.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}