Repository navigation
fix(ship): remove the CodeRabbit guard hook - #24
Conversation
…Rabbit succeeded The hook blocked every merge in any repo with a .coderabbit.yaml unless the CodeRabbit check succeeded, so a docs-only PR that CodeRabbit skips, or a PR reviewed by another reviewer, could not be merged. ship still waits for CodeRabbit itself.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Remove merge guard registrations and behavior .claude-plugin/marketplace.json, skills/ship/hooks/*, tests/test_guard_merge.py, README.md, .coderabbit.yaml |
The marketplace entries no longer register the merge hook. The hook configuration, implementation, and tests are deleted. The README description and .coderabbit.yaml comment about the guard are also removed. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- killallgit/killall-skills#21: Added the merge guard implementation and registration that this PR removes.
- killallgit/killall-skills#22: Changed the same merge hook and added a workflow that can run a PR merge.
Merge Risk: 
34ea2
-
The merge guard is removed as intended. No merge-blocking risk was identified.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: removing the CodeRabbit guard hook from the ship skill. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Removes the ship skill's PreToolUse hook (guard-merge.sh), its test and its README paragraph, and regenerates the manifest so neither the ship entry nor the killall-skills bundle installs it.
The hook blocked every merge in a repo with a .coderabbit.yaml unless the CodeRabbit check had succeeded. A docs-only PR that CodeRabbit skips, or a PR reviewed by another reviewer, could not be merged. The ship skill still waits for CodeRabbit in its own steps.
Tests: 70 passed.
Summary by CodeRabbit