docker: fix pylibfdt build with swig 4.5 - #3192
Merged
Merged
Conversation
Installing dtschema and dt-schema pulls in pylibfdt, which has no binary wheels and is built from source. Its pyproject.toml lists swig as a build dependency, so pip's build isolation fetches the newest release from PyPI instead of using the distro package. swig 4.5.0 removed the Python 2 compatibility macros from its runtime header pyhead.swg, while pylibfdt still uses PyString_FromString() and PyInt_AsLong() in its typemaps, so the generated wrapper no longer compiles: libfdt/libfdt_wrap.c:5555:20: error: implicit declaration of function 'PyInt_AsLong'; did you mean 'PyLong_AsLong'? Define the two macros on the compiler command line, using the same replacements as the upstream fix in dtc commit 5008d1d6a356. They can be dropped once a pylibfdt release picks that fix up. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix staging failure"
libfdt/libfdt_wrap.c:5555:20: error: implicit declaration of function 'PyInt_AsLong'; did you mean 'PyLong_AsLong'?Define the two macros on the compiler command line, using the same replacements as the upstream fix in dtc commit 5008d1d6a356. They can be dropped once a pylibfdt release picks that fix up.