Skip to content

Render generic identifiers as text inputs - #28

Open
masnwilliams wants to merge 1 commit into
mainfrom
hypeship/render-identifiers-as-text
Open

Render generic identifiers as text inputs#28
masnwilliams wants to merge 1 commit into
mainfrom
hypeship/render-identifiers-as-text

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

summary

  • render canonical identifier fields as text inputs regardless of their credential ref
  • preserve combined username, email, and phone labels without browser-native email or telephone validation
  • add regression coverage for email-, username-, and phone-named canonical identifiers

testing

  • bun test
  • bun run build
  • bun run typecheck
  • bun run format:check

release

Includes a patch changeset for @onkernel/managed-auth-react.


Note

Low Risk
Client-side login form mapping only; no auth protocol or credential handling changes, with a small UX tradeoff (less strict HTML5 validation on identifier inputs).

Overview
Canonical identifier fields are always projected to text discovered fields instead of inferring email or tel from the credential ref.

That removes browser-native email/telephone validation and keeps server-provided labels (e.g. combined “Mobile number, username, or email”) intact for username-, email-, and phone-style refs. Regression expectations in state.test.ts were updated accordingly, and a patch changeset was added for @onkernel/managed-auth-react.

Reviewed by Cursor Bugbot for commit 23f36af. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
managed-auth-react-demo Ready Ready Preview Aug 30, 2026 11:08pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant