Render typed managed auth errors - #27
Open
masnwilliams wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
dependency
Merge and deploy kernel/kernel#3666 before publishing this package. The component remains backward-compatible with the existing API because unknown and older codes retain their current fallback behavior.
validation
bun testbun run typecheckbun run format:checkbun run buildNote
Low Risk
UI-only error copy in managed-auth-react; unknown error codes still use existing localization fallbacks.
Overview
StepErrornow maps new managed-autherror_codevalues to dedicated titles and recovery copy instead of the generic error fallback.Adds display entries for reauthentication blockers (
totp_required,sms_code_required,email_code_required,account_choice_required,customer_input_required,external_action_required) with neutral wording that avoids “reauth” in user-facing text.totp_code_rejectedgets its own message (fresh code / reconnect guidance) so it is not conflated withcredentials_invalid.Lookup is exposed as
errorDisplayForCodefor testing;StepErroruses that helper unchanged for unknown or legacy codes. Patch changeset for@onkernel/managed-auth-react; tests cover the new mappings.Reviewed by Cursor Bugbot for commit 850d202. Bugbot is set up for automated code reviews on this repo. Configure here.