Skip to content

Guard consent until session initialization - #25

Merged
masnwilliams merged 5 commits into
mainfrom
hypeship/guard-prime-before-init
Aug 24, 2026
Merged

Guard consent until session initialization#25
masnwilliams merged 5 commits into
mainfrom
hypeship/guard-prime-before-init

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep the consent/prime layout visible while the handoff code and initial session state load
  • show generic preparation copy plus a disabled Loading... action until connection metadata is ready
  • restore domain-specific copy and the normal Continue action after initialization
  • keep skipPrimeStep sessions on discovery UI throughout initialization
  • reset stale session data when the session identity changes
  • cover delayed, failed, and skip-prime initialization behavior

Why

The consent action could render before initialization completed. An immediate click had no JWT to use and was ignored. Keeping initialization within the consent layout fixes the race without adding another full-screen state or a discovery → consent → discovery sequence.

Validation

  • bun test
  • bun run typecheck
  • bun run build
  • bun run format:check
  • npm pack --dry-run --workspace packages/managed-auth-react

@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
managed-auth-react-demo Ready Ready Preview Aug 24, 2026 5:19pm

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 93e79fd. Configure here.

Comment thread packages/managed-auth-react/src/KernelManagedAuth.tsx
Comment thread packages/managed-auth-react/src/KernelManagedAuth.tsx
@masnwilliams
masnwilliams merged commit eca48fa into main Aug 24, 2026
5 checks passed
@masnwilliams
masnwilliams deleted the hypeship/guard-prime-before-init branch August 24, 2026 17:30
@github-actions github-actions Bot mentioned this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant