Skip to content

Reap the log aggregator's tail processes #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sayan- merged 2 commits into from
Aug 25, 2026
+11 −0
Merged

Reap the log aggregator's tail processes #350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf73a4d
Reap the log aggregator's tail processes
Sayan- Aug 24, 2026
20a0f55
Merge branch 'main' into hypeship/wrapper-tail-wait
masnwilliams Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions server/cmd/wrapper/supervisord.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,17 @@ func tailFile(path string) {
for scanner.Scan() {
fmt.Printf("[%s] %s\n", label, scanner.Text())
}
// A clean scan ends when tail closes its stdout, i.e. when it has exited.
// A scan that ends on an error (a log line past the 1MB cap, say) leaves
// tail running, so kill it rather than block here forever.
//
// Either way we have to collect it: the wrapper is pid 1 in both the
// container and the unikernel, so a tail nobody waits on stays a zombie
// for the life of the instance.
if scanner.Err() != nil {
_ = cmd.Process.Kill()
}
_ = cmd.Wait()
}

func runStream(label, name string, args ...string) error {
Expand Down
Loading